color: moving color args out of build verb and into main program args #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbohren
force-pushed
the
global-color-args
branch
from
37678cc
to
e5ef59a
Compare
| @@ -145,6 +136,10 @@ def prepare_arguments(parser): | |||
| add('--no-summarize', '--no-summary', action='store_false', dest='summarize', | |||
| help='explicitly disable the end of build summary') | |||
|
|
|||
| # Deprecated args now handled by sysargs | |||
There was a problem hiding this comment.
"not handled by catkin command"?
There was a problem hiding this comment.
Yeah I'll change that
|
Other than the comment, +1 |
|
Does catkin make use of |
|
I actually just tested this and this PR appears to achieve that. |
jbohren
force-pushed
the
global-color-args
branch
from
e5ef59a
to
5031e01
Compare
|
@wjwwood Updated the requested comment change. |
wjwwood
added a commit
that referenced
this pull request
Mar 16, 2015
color: moving color args out of build verb and into main program args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are now a bunch of subcommands in
catkin_toolswhich generate color, so this moves the actual processing of these arguments into the maincatkincommand. Note that the arguments still exist in thecatkin buildverb, but they are hidden.