Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verbs: adding shell verbs 'cd' and 'source' #192

Closed
wants to merge 1 commit into from

Conversation

jbohren
Copy link
Contributor

@jbohren jbohren commented Apr 7, 2015

NOTE: Depends on #165

This is a bash/zsh wrapper function which, when sourced, enables the following:

  • catkin cd [ARGS...] -- Change to package directory in source space where ARGS are any valid catkin locate arguments
  • catkin source -- Source the develspace of the containing workspace
  • catkin -w /path/to/ws source -- Source the develspace of the workspace /path/to/ws source

@wjwwood
Copy link
Member

wjwwood commented Apr 15, 2015

This one needs to be updated with catkin find => catkin locate.

@jbohren
Copy link
Contributor Author

jbohren commented Apr 15, 2015

This one needs to be updated with catkin find => catkin locate.

Yep.

@jbohren
Copy link
Contributor Author

jbohren commented Jun 11, 2015

I updated it to use locate instead of find.

@wjwwood
Copy link
Member

wjwwood commented Dec 9, 2015

This is neither documented nor automatically sourced. So before merging this it needs to be documented.

@k-okada you mentioned it should be added to the bug squashing list, can you test and document the feature (both how to activate it and how to use it)?

@k-okada
Copy link
Contributor

k-okada commented Dec 9, 2015

ok, so where should I put documents?

◉ Kei Okada

On Thu, Dec 10, 2015 at 2:14 AM, William Woodall notifications@github.com
wrote:

This is neither documented nor automatically sourced. So before merging
this it needs to be documented.

@k-okada https://github.com/k-okada you mentioned it should be added to
the bug squashing list, can you test and document the feature (both how to
activate it and how to use it)?


Reply to this email directly or view it on GitHub
#192 (comment).

@wjwwood
Copy link
Member

wjwwood commented Dec 9, 2015

I'd add a "Extra catkin shell commands" section to the index:

https://github.com/catkin/catkin_tools/blob/master/docs/index.rst

Where you can describe that these are shell functions and that they can be optionally activated by source'ing the file in this pr. Then a bullet list of the new shell commands and either a short description of each or a link to another document in the docs folder which has more detail (similar to the list of built-in verbs).

k-okada added a commit to k-okada/catkin_tools that referenced this pull request Dec 10, 2015
k-okada added a commit to k-okada/catkin_tools that referenced this pull request Dec 10, 2015
k-okada added a commit to k-okada/catkin_tools that referenced this pull request Dec 10, 2015
@k-okada
Copy link
Contributor

k-okada commented Dec 10, 2015

@wjwwood added docs to #244,
this is not verb, but shell support and activated by 'source /opt/ros/indigo/etc/bash_completion.d/catkin_shell_verbs.bash', just to make sure this is not automatically loaded in `source /opt/ros/indigo/setup.bash'

k-okada added a commit to k-okada/catkin_tools that referenced this pull request Dec 10, 2015
k-okada added a commit to k-okada/catkin_tools that referenced this pull request Dec 11, 2015
k-okada added a commit to k-okada/catkin_tools that referenced this pull request Dec 11, 2015
@wjwwood
Copy link
Member

wjwwood commented Dec 21, 2015

This was replaced by #244.

@wjwwood wjwwood closed this Dec 21, 2015
@k-okada
Copy link
Contributor

k-okada commented Dec 21, 2015

thank you!

◉ Kei Okada

On Mon, Dec 21, 2015 at 9:30 AM, William Woodall notifications@github.com
wrote:

Closed #192 #192.


Reply to this email directly or view it on GitHub
#192 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants