Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR196 *] Adding documentation for forthcoming changes in 0.4.0 #250

Closed
wants to merge 12 commits into from

Conversation

jbohren
Copy link
Contributor

@jbohren jbohren commented Dec 16, 2015

View online here: http://jbohren-ct.readthedocs.org/en/pre-0.4.0-docs/

Includes the following:

  • new execution framework design
  • sets local sphinx style to readthedocs style
  • reorganizes main index for easier navigation

To build locally:

cd docs
make html

Outstanding Issues

@jbohren jbohren changed the title Adding documentation for forthcoming changes in 0.4.0 (PR#196) [PR196] Adding documentation for forthcoming changes in 0.4.0 Dec 18, 2015
@jbohren jbohren changed the title [PR196] Adding documentation for forthcoming changes in 0.4.0 [PR196 *] Adding documentation for forthcoming changes in 0.4.0 Dec 18, 2015
@jbohren
Copy link
Contributor Author

jbohren commented Dec 21, 2015

This has been rebased to incorporate changes from #244 and the new test harness.

@NikolausDemmel
Copy link
Member

a.k.a. "turbo" option

This is gold :-D

I've been using it and it really is a turbo for large workspaces.

…local sphinx style, and reorganizing main index
- updated build type stages
- added scripts for recording examples
- added scripts for capturing CLI interfaces to txt files
- moved catkin tools history to specific history page
- simplified index
- updated build mechanics for new features
- added migration guide with troubleshooting based on observed use cases
- updated quick start with asciinemas
- updated build with asciinemas
- added env verb
- added example resources to installation
Alexander Schaefer and others added 5 commits February 26, 2016 11:47
Conflicts:
	docs/mechanics.rst
	docs/quick_start.rst
- regenerating examples and cli interfaces
- switching all text to sentence-per-line
- adding scripts and documentation for regenerating examples
- moving --locate-extra-shell-verbs to locate verb
- adding details on linked develspace
@jbohren
Copy link
Contributor Author

jbohren commented Apr 13, 2016

@wjwwood These docs are all updated for all of the pre-0.4.0 changes and should be good to merge.


Each of the following verbs is built-in to the ``catkin`` command and has its own detailed documentation:

- :doc:`build -- Build packages in a catkin workspace <verbs/catkin_build>`
- :doc:`config -- Configure a catkin workspace's layout and settings <verbs/catkin_config>`
- :doc:`clean -- Clean products generated in a catkin workspace <verbs/catkin_clean>`
- :doc:`create -- Create structures like Catkin packages <verbs/catkin_create>`
- :doc:`env -- Run commands with a modified environemnt <verbs/catkin_env>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling: environemnt

@jbohren
Copy link
Contributor Author

jbohren commented Apr 13, 2016

@wjwwood All tests passing. If you merge this, I can send out the call for testing once the docs are live on rtd.

@wjwwood
Copy link
Member

wjwwood commented Apr 13, 2016

@jbohren that sounds good, I'm looking at it now.

@jbohren
Copy link
Contributor Author

jbohren commented Apr 13, 2016

@wjwwood Hold on merging while I add a module to sphinx to check spelling, there are more mistakes than the ones @dirk-thomas found, obviously.

@wjwwood
Copy link
Member

wjwwood commented Apr 13, 2016

@jbohren great idea. I'm still reviewing it anyways.

@jbohren
Copy link
Contributor Author

jbohren commented Apr 14, 2016

@wjwwood 53d1205 should now fail if there are any spelling errors (there still are, but I want to see it break the CI before fixing it)

@jbohren
Copy link
Contributor Author

jbohren commented Apr 14, 2016

Ok it looks like it's working on OSX but needs an Ubuntu system package.

@jbohren
Copy link
Contributor Author

jbohren commented Apr 14, 2016

We now have CI doc spell checking.

@wjwwood
Copy link
Member

wjwwood commented Apr 14, 2016

I rebuilt this branch on RTD, so that I can see the updated output from the shell scripts. Does this need to be rebased since #293.

@wjwwood
Copy link
Member

wjwwood commented Apr 14, 2016

That last sentence should have been a question. Otherwise I think things like the "log" space won't show up in the output of the quickstart page.

@wjwwood
Copy link
Member

wjwwood commented Apr 14, 2016

I think you should rebase this before merging. I just looked at the merged result and it resulted in some strange three-way merges which I'm not convinced make sense afterwards. Related to that is that rebasing cannot be done cleanly. I can also not squash it properly. Not sure what's going on.

Also your CI job doesn't work with the latest change (it timed-out because you don't pass -y to apt-get).

@wjwwood
Copy link
Member

wjwwood commented Apr 14, 2016

It's really strange because the commit e5c5224 is in this pr's commit list, but it doesn't show up in the log of a clean git clone https://github.com/catkin/catkin_tools -b pre-0.4.0-docs. Not sure what's going on.

@wjwwood
Copy link
Member

wjwwood commented Apr 14, 2016

Never mind, I have the commit, but it's way back in the git log. It's a very strange branch.

@wjwwood
Copy link
Member

wjwwood commented Apr 14, 2016

@jbohren I pushed a branch of this which is rebased on master: https://github.com/catkin/catkin_tools/tree/pre-0.4.0-docs-rebase (including your latest commit a2e21ee) if you're interested. That one Fix typos commit really screwed things up.

@wjwwood
Copy link
Member

wjwwood commented Apr 14, 2016

btw, it looks like the RTD build fails because of your spellchecker: http://readthedocs.org/projects/catkin-tools/builds/3906804/

@jbohren jbohren mentioned this pull request Apr 14, 2016
@jbohren
Copy link
Contributor Author

jbohren commented Apr 14, 2016

@jbohren I pushed a branch of this which is rebased on master: https://github.com/catkin/catkin_tools/tree/pre-0.4.0-docs-rebase (including your latest commit a2e21ee) if you're interested. That one Fix typos commit really screwed things up.

Yeah I created a PR from it as #318. You mean the fix typos commit 472ead0? I was trying to make sure @fudger's commit was in there in a reasonable way, it looks like your rebase did it properly, though.

btw, it looks like the RTD build fails because of your spellchecker: http://readthedocs.org/projects/catkin-tools/builds/3906804/

I added a separate sphinx conf to be used for the CI only over in #318.

Closing this in favor of #318.

@jbohren jbohren closed this Apr 14, 2016
@jbohren jbohren deleted the pre-0.4.0-docs branch April 14, 2016 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants