Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: Adding tests (and ci configs) which fail on El Capitan (0.4.x) #355

Closed
wants to merge 6 commits into from
Closed

testing: Adding tests (and ci configs) which fail on El Capitan (0.4.x) #355

wants to merge 6 commits into from

Conversation

jbohren
Copy link
Contributor

@jbohren jbohren commented Apr 22, 2016

No description provided.

@jbohren jbohren mentioned this pull request Apr 22, 2016
Open
@wjwwood
Copy link
Member

wjwwood commented Apr 22, 2016

Needs a rebase now? (there seem to be commits from the one I just merged #353)

@jbohren
Copy link
Contributor Author

jbohren commented Apr 22, 2016

Yeah I'll rebase this. Also we can hold off on merging it until we figure out what the fix is.

@jbohren jbohren force-pushed the fix-354 branch 6 times, most recently from 997a064 to 3aa5704 Compare April 22, 2016 21:11
@jbohren jbohren force-pushed the fix-354 branch 2 times, most recently from d84928f to f653b2a Compare April 22, 2016 22:14
@jbohren jbohren changed the title Test to repro #354 testing: Adding tests (and ci configs) which fail on El Capitan Apr 22, 2016
@jbohren jbohren changed the title testing: Adding tests (and ci configs) which fail on El Capitan testing: Adding tests (and ci configs) which fail on El Capitan (0.4.x) Apr 23, 2016
@jbohren
Copy link
Contributor Author

jbohren commented May 5, 2016

@wjwwood So I added two commits which make ctest work with plain CMake packages on El Capitan with SIP.

First, a491706 simply enables CMAKE_MACOSX_RPATH by default. This fixes running ctest in a linked develspace.

Second, 9c8b3be adds a Catkin package to the merged develspace test, which is apparently necessary to set up the environment. This means that there's something that the Catkin setup files are doing that the vanilla CMake ones aren't.

@wjwwood
Copy link
Member

wjwwood commented Jan 31, 2017

Just catching up on this issue, I do not think we can set CMAKE_MACOSX_RPATH by default in catkin tools because I think it is a choice that the developer and/or the packages being built should make. So we'll either have to decline this whole pr, or find a way to run these tests without SIP interfering. On my machines I just ended up disabling SIP, as it was just too painful to deal with.

@mikepurvis
Copy link
Member

Closing due to inactivity.

@mikepurvis mikepurvis closed this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbohren @wjwwood @mikepurvis