Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Adding option to show full stdout if a stage fails #362

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jbohren
Copy link
Contributor

@jbohren jbohren commented Apr 28, 2016

No description provided.

@jbohren
Copy link
Contributor Author

jbohren commented Apr 28, 2016

This fixes #361

@wjwwood
Copy link
Member

wjwwood commented Apr 28, 2016

As I mentioned in the other issue, my personal opinion is that this should be the default behavior and there could be a option or setting that switches it to the current behavior. (This underscores the need for a workspace agnostic catkin tools settings, something like ~/.catkin_tools.conf)

@mikepurvis
Copy link
Member

Strongly in support of this. Any chance it can target 0.4.3?

@wjwwood
Copy link
Member

wjwwood commented Aug 5, 2016

I was going to open a new pr that inverts the logic, so that printing stdout was the default behavior and you could configure catkin_tools through a user level config to do the current behavior. However, I haven't had time to do this. Hopefully I'll have a week to catch up on this repository and the others like rvizin the coming month.

@Levi-Armstrong
Copy link

Would this address issue #419?

@wjwwood
Copy link
Member

wjwwood commented Jan 3, 2017

@Levi-Armstrong I believe so.

@rhaschke
Copy link
Contributor

rhaschke commented Jan 10, 2017

Would this address issue #419?

@wjwwood I don't think so. #419 will be fixed with #400. This PR collects all output (stdout + stderr) from the process and prints it on stdout, doesn't it?

@wjwwood
Copy link
Member

wjwwood commented Jan 11, 2017

@rhaschke I think you may be right. I am getting the "how much to print out" versus "where to print what out" confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants