Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rebase of issue 399 #433

Closed
wants to merge 1 commit into from
Closed

rebase of issue 399 #433

wants to merge 1 commit into from

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Feb 8, 2017

See #399

@wjwwood
Copy link
Member Author

wjwwood commented Feb 8, 2017

@rhaschke this is still failing in Python 3 even after I rebased it (again since merging #428) and the master branch is passing: #434

At first glance I'm not sure what the issue is.

@mkoval
Copy link

mkoval commented Apr 5, 2017

I can confirm that this fixed #311 on an Ubuntu 14.04 machine using Python 2. Unfortunately, I have no idea what the original source of this error was or why the tests are currently failing on Python 3.

@arpit15
Copy link

arpit15 commented Apr 6, 2017

This commit solved #311 for me on Ubuntu 14.04 with Python 2.

@rhaschke rhaschke mentioned this pull request Apr 7, 2017
Merged
@wjwwood
Copy link
Member Author

wjwwood commented Apr 7, 2017

Closing due to #399 (comment)

@wjwwood wjwwood closed this Apr 7, 2017
@wjwwood wjwwood deleted the rhaschke-fix-#311 branch April 7, 2017 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wjwwood @mkoval @arpit15 @rhaschke