Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty file in get_metadata correctly #568

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Handle empty file in get_metadata correctly #568

merged 1 commit into from
Nov 25, 2019

Commits on Sep 16, 2019

  1. Handle empty file in get_metadata correctly 

    If the `metadata_file_path` exists but the `metadata_file` is empty, `yaml.safe_load(metadata_file)` will return None. But the caller expects a dictionary which can lead to a crash. (e.g. in https://github.com/catkin/catkin_tools/blob/master/catkin_tools/verbs/catkin_build/cli.py#L371)
    @Mofef
    Mofef authored Sep 16, 2019
    Configuration menu
    Copy the full SHA
    416ae17 View commit details
    Browse the repository at this point in the history