feat(pythonanywhere): init #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
|
I might pick this up and finish it |
|
Feel free to. You should be able to just push to this branch I think? Lmk. |
uncenter
commented
Nov 11, 2024
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
uncenter
commented
Nov 11, 2024
uncenter
commented
Nov 11, 2024
trinkey
reviewed
Nov 11, 2024
trinkey
previously approved these changes
Nov 11, 2024
|
What classes are unthemed for Ace? Do you mind theming them before we merge this? |
uncenter
commented
Nov 12, 2024
|
Cool, I'm all set with this. Any last concerns @isabelroses @trinkey? (I can't approve my own PR.) |
|
lgtm (i would review but i cant find the button in github mobile app) |
isabelroses
approved these changes
Nov 12, 2024
(For the record go to Files Changed for the PR (the diff) and then the Finish Review button should be at the bottom of the screen and you can approve through there.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just leaving this here if anyone wants to pickup (I might again at some point). Follows #1217, which was based upon #776. Did some fixes myself originally for #1217 but seeing as that is closed... didn't want my time to go to waste.