Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gmail): emails on organization accounts #1469

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(gmail): emails on organization accounts #1469

wants to merge 3 commits into from

Conversation

JasonLovesDoggo
Copy link

Before:
image

After:
image

@github-actions github-actions bot added the gmail Gmail label Nov 21, 2024
@JasonLovesDoggo JasonLovesDoggo changed the title Fix: Gmail emails on organization accounts being improperly colored fix: Gmail emails on organization accounts being improperly colored Nov 21, 2024
@uncenter uncenter changed the title fix: Gmail emails on organization accounts being improperly colored fix(gmail): emails on organization accounts Nov 21, 2024
@uncenter
Copy link
Member

You sure those aren't supposed to be a different color, for unread emails? I'm guessing they don't match the original read email selector for a reason?

@JasonLovesDoggo
Copy link
Author

You sure those aren't supposed to be a different color, for unread emails? I'm guessing they don't match the original read email selector for a reason?

You can't see in my screenshot but the unread ones look normal I'll send an expanded screenshot tomorrow

@JasonLovesDoggo
Copy link
Author

JasonLovesDoggo commented Nov 25, 2024 •
edited by uncenter
Loading

image

@uncenter
Copy link
Member

I mean unread emails should be a different color?

CleanShot 2024-11-26 at 05 48 10

CleanShot 2024-11-26 at 05 48 22

@JasonLovesDoggo
Copy link
Author

I mean unread emails should be a different color?

CleanShot 2024-11-26 at 05 48 10

CleanShot 2024-11-26 at 05 48 22

Ah, probably so. I was just submitting this to fix Gmail being downright unusable in that white background state

@catppuccin catppuccin deleted a comment from JasonLovesDoggo Nov 26, 2024
@uncenter
Copy link
Member

uncenter commented Dec 5, 2024

Is that fixed now? I think we left off agreeing that unread emails should have that different background color?

@uncenter uncenter added the waiting on author Note for staff that a re-review is not yet required label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uncenter uncenter Awaiting requested review from uncenter uncenter is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
gmail Gmail waiting on author Note for staff that a re-review is not yet required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonLovesDoggo @uncenter