Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add script to generate dark reader ignore configuration #962

Merged
0 commits merged into from
Jun 7, 2024

Conversation

Magniquick
Copy link

This creates a dark-reader.ts that traverses the entire repository to create exclusion rules for dark reader.
Initially written in python, rewritten in deno following popular demand.
This still breaks on anything more complex than a bare domain, (probably) due to escaping shenanigans with regex.
eg: google.com is broken, but mail.google.com works.

@Magniquick Magniquick changed the title create dark-reader.ts feat: add dark reader support. Jun 6, 2024
@uncenter uncenter changed the title feat: add dark reader support. ci: add script to generate dark reader ignore configuration Jun 6, 2024
@mustafakhalaf-git mustafakhalaf-git closed this pull request by merging all changes into catppuccin:main in 141406e Jun 7, 2024
@Magniquick
Copy link
Author

this was a WIP, but ok ig ?

@uncenter
Copy link
Member

uncenter commented Jun 7, 2024

It wasn't merged. Look at the diff. Do you have the pull bot configured on your account? Looks like it messed up some stuff.

@Magniquick
Copy link
Author

O.O
lemme see

@Magniquick
Copy link
Author

fixed, making a new pr

@mustafakhalaf-git
Copy link
Member

mustafakhalaf-git commented Jun 8, 2024

this was a WIP, but ok ig ?

@Magniquick huh, I actually don't recall doing anything related to this yesterday, no idea why this happened weird.

@uncenter
Copy link
Member

uncenter commented Jun 8, 2024

this was a WIP, but ok ig ?

@Magniquick huh, I actually don't recall doing anything related to this yesterday, no idea why this happened weird.

Weird GitHub things. Don't worry about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants