Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MaxGrowthRate #851

Closed
dsalaza4 opened this issue May 24, 2023 · 4 comments · Fixed by #962
Closed

Support MaxGrowthRate #851

dsalaza4 opened this issue May 24, 2023 · 4 comments · Fixed by #962
Labels
enhancement 🆕 New feature or request

Comments

@dsalaza4
Copy link

Describe the solution you'd like

The module already supports parameters like idleCount.

Maybe it should also support MaxGrowthRate: https://docs.gitlab.com/runner/configuration/advanced-configuration.html#the-runnersmachine-section
@kayman-mk kayman-mk added the enhancement 🆕 New feature or request label May 24, 2023
@kayman-mk
Copy link
Collaborator

Valid point. Version 7 adds many parameters. Guess we should add MaxGrowthRate to #723

@dsalaza4
Copy link
Author

dsalaza4 commented May 25, 2023 •
edited
Loading

Looking forward to this!

I'm currently trying a completely on demand approach (idle-count = 0), but runners tend to leave orphaned workers.

I think it is because they run out of memory when very big workloads reach them in a very short amount of time (From 0 to 300 jobs leaves some orphaned workers for a 8GB memory runner).

Having a MaxGrowthRate should allow the runner to scale up efficiently without reaching its memory limits.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Jul 25, 2023
@kayman-mk kayman-mk removed the stale Issue/PR is stale and closed automatically label Jul 27, 2023
@rohaquinlop rohaquinlop mentioned this issue Sep 18, 2023
Merged
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Sep 26, 2023
@kayman-mk kayman-mk removed the stale Issue/PR is stale and closed automatically label Sep 28, 2023
kayman-mk added a commit that referenced this issue Sep 28, 2023
@rohaquinlop @kayman-mk
feat: add MaxGrowthRate to limit the number of instances added in p…
ae6d38a 
…arallel (#962)

## Description

This feature allows to support `MaxGrowthRate` which limits the number
of instances added in parallel by the Runner. The default of `0`
(unlimited) is used if no value is given.

The parameter is added to `runner_worker_docker_machine_instance` as
this is the only Runner type for which it makes sense. All other types
are not able to scale and thus it is not a `runner_worker` parameter.

See
[advanced-configuration](https://docs.gitlab.com/runner/configuration/advanced-configuration.html#the-runnersmachine-section)

Closes #851 

## Migrations required

NO

## Verification

- do not set the parameter --> `MaxGrowthRate` in config file is 0.
- set the parameter to any value --> `MaxGrowthRate` in config file is
"any value"

---------

Co-authored-by: Matthias Kay <github@matthiaskay.de>
Co-authored-by: Matthias Kay <matthias.kay@hlag.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🆕 New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@dsalaza4 @kayman-mk