fix: remove the deprecated runner_user_data output variable

[ryancausey]

Description

Depending on the value of the output a call to nonsensitive is needed. Instead of introducing a conditional call, we remove the output variable. The value is still written to a local file, see debug.write_runner_user_data_to_file.

Closes #1031.

Migrations required

YES - any use of the runner-user-data output must be changed to use var.debug.write_runner_user_data_to_file. As this is used for debug only, it shouldn't be a problem for your live environment.

Verification

None. Just removing the output variable.

[github-actions]

Hey @ryancausey! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

• the problem being solved
• the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

• /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

[ryancausey]

I just noticed #1018 and #1019, so I've changed this to always mark this variable as sensitive.

[kayman-mk]

As this variable is already deprecated and used for debugging only, we should simply delete it (like in #1019). Users can set debug.write_runner_user_data_to_file to true to write the data to the local disk.

[kayman-mk]

Thanks for improving the module, @ryancausey