Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove v in tags to enable automatic push to Terraform registry #1081

Merged
merged 8 commits into from
Feb 8, 2024

Conversation

kayman-mk
Copy link
Collaborator

@kayman-mk kayman-mk commented Feb 8, 2024

Description

Due to a major change in release-please our configuration was ignored and the tags created for a release started with v. But the Terraform registry expects a semantic version only.

This PR updates the release-please configuration to make it compatible with version 4.

Closes #1048

@kayman-mk kayman-mk requested a review from npalm as a code owner February 8, 2024 11:12
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 1 0 0.01s
✅ COPYPASTE jscpd yes no 1.52s
✅ JSON eslint-plugin-jsonc 2 0 0 0.92s
✅ JSON jsonlint 2 0 0.21s
✅ JSON prettier 2 0 0 0.63s
✅ JSON v8r 2 0 2.33s
✅ REPOSITORY checkov yes no 14.11s
✅ REPOSITORY dustilock yes no 0.1s
✅ REPOSITORY gitleaks yes no 1.08s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 10.65s
✅ REPOSITORY secretlint yes no 1.57s
✅ REPOSITORY syft yes no 0.36s
✅ REPOSITORY trivy-sbom yes no 0.96s
✅ REPOSITORY trufflehog yes no 2.17s
✅ SPELL cspell 4 0 2.62s
✅ YAML prettier 1 0 0 0.54s
✅ YAML v8r 1 0 2.12s
✅ YAML yamllint 1 0 0.33s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@kayman-mk kayman-mk force-pushed the kayma/release-please-config branch from 44c317e to 7b9d4ae Compare February 8, 2024 11:34
@kayman-mk
Copy link
Collaborator Author

Configuration files created with release-please release-pr --token=$GITHUB_TOKEN --repo-url=cattle-ops/terraform-aws-gitlab-runner --target-branch=release-please/bootstrap/default --debug --dry-run

@kayman-mk
Copy link
Collaborator Author

Configuration tested with release-please release-pr --token=$GITHUB_TOKEN --repo-url=cattle-ops/terraform-aws-gitlab-runner --target-branch=kayma/release-please-config --debug --dry-run --manifest-file .github/.r elease-please-manifest.json --config-file .github/.release-please-config.json

@kayman-mk kayman-mk merged commit 29da6ed into main Feb 8, 2024
19 checks passed
@kayman-mk kayman-mk deleted the kayma/release-please-config branch February 8, 2024 15:05
kayman-mk pushed a commit that referenced this pull request Feb 8, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.3.1](v7.3.0...7.3.1)
(2024-02-08)


### Bug Fixes

* remove `v` in tags to enable automatic push to Terraform registry
([#1081](#1081))
([29da6ed](29da6ed)),
closes
[#1048](#1048)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant