Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repair errors in startup shell script #1087

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

kayman-mk
Copy link
Collaborator

@kayman-mk kayman-mk commented Feb 15, 2024

Description

The startup shell script of the Agent instance was broken due to missing tests (to be addressed in #1088 ). Fixed the script and validated it with shellchecker.

  • if needs then
  • no spaces in = assignments
  • use $ to get the value of a variable

Verification

  • module deployed in the test environment. Runners were spawn, jobs processed.
  • Cloudwatch logs checked for errors, none found

@kayman-mk kayman-mk requested a review from npalm as a code owner February 15, 2024 10:05
Copy link
Contributor

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

Copy link
Contributor

github-actions bot commented Feb 15, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.73s
✅ REPOSITORY checkov yes no 15.24s
✅ REPOSITORY dustilock yes no 0.22s
✅ REPOSITORY gitleaks yes no 1.18s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.63s
✅ REPOSITORY secretlint yes no 1.11s
✅ REPOSITORY syft yes no 0.39s
✅ REPOSITORY trivy-sbom yes no 1.32s
✅ REPOSITORY trufflehog yes no 8.36s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@kayman-mk kayman-mk merged commit 9b7c465 into main Feb 15, 2024
21 checks passed
@kayman-mk kayman-mk deleted the kayma/fix-shell-error branch February 15, 2024 10:20
kayman-mk pushed a commit that referenced this pull request Feb 15, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.4.0](7.3.1...7.4.0)
(2024-02-15)


### Features

* error checking for initial API token call
([#1080](#1080))
([6b3740a](6b3740a))


### Bug Fixes

* rename `pull_policies` to `pull_policy` in `config.toml`
([#1084](#1084))
([df39014](df39014))
* repair errors in startup shell script
([#1087](#1087))
([9b7c465](9b7c465))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant