Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use existing Runner package for Amazon Linux 2023 as default #1155

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

kayman-mk
Copy link
Collaborator

@kayman-mk kayman-mk commented Jul 22, 2024

Description

Since #1138 was merged, the runner_gitlab.runner_version was wrong. The mentioned package 15.8.2 does not exist for Amazon Linux 2023. This PR updates the default version to 16.0.3 the oldest available version.

You should never rely on the default value as your Runner has to match the GitLab version. See https://docs.gitlab.com/runner/#gitlab-runner-versions

Closes #1147

Migrations required

Usually not. In case you are still on GitLab < 16 you have to use the old AMI matching amzn2-ami-hvm-2.*-x86_64-ebs (used before #1138 was merged). Then you are able to still use an older version of the Runner.

Verification

  • verified that 16.0.3 is available. Installation is done via
  curl --fail --retry 6 -L https://packages.gitlab.com/install/repositories/runner/gitlab-runner/script.rpm.sh | bash
  yum install gitlab-runner-${gitlab_runner_version} -y

@kayman-mk kayman-mk requested a review from npalm as a code owner July 22, 2024 09:09
Copy link
Contributor

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

Copy link
Contributor

github-actions bot commented Jul 22, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.62s
✅ REPOSITORY checkov yes no 14.88s
✅ REPOSITORY dustilock yes no 0.27s
✅ REPOSITORY gitleaks yes no 1.3s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 12.29s
✅ REPOSITORY secretlint yes no 1.09s
✅ REPOSITORY syft yes no 0.45s
✅ REPOSITORY trivy-sbom yes no 1.18s
✅ REPOSITORY trufflehog yes no 3.99s
✅ SPELL cspell 2 0 2.66s
✅ TERRAFORM terraform-fmt 1 0 0 0.06s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@kayman-mk kayman-mk changed the title fix: use existing Runner package for Amazon Linux 2023 fix: use existing Runner package for Amazon Linux 2023 as default Jul 22, 2024
@kayman-mk kayman-mk merged commit c001183 into main Jul 22, 2024
19 checks passed
@kayman-mk kayman-mk deleted the kayma/fix-pre-commit-warnings branch July 22, 2024 09:46
kayman-mk pushed a commit that referenced this pull request Jul 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.9.0](7.8.0...7.9.0)
(2024-07-22)


### Features

* add support for configuring runner worker root device name
([#1140](#1140))
([a1f8266](a1f8266))


### Bug Fixes

* increase timeout for EC2 termination lambda
([#1156](#1156))
([2bf6d3d](2bf6d3d))
* remove leading `/` from SSM parameter names in policy ARNs
([#1146](#1146))
([beea51d](beea51d))
* use existing Runner package for Amazon Linux 2023 as default
([#1155](#1155))
([c001183](c001183))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitLab Runner 15.8.2 can't be installed on Amazon Linux 2023
1 participant