Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variables to specify the AMI ids #1214

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

kayman-mk
Copy link
Collaborator

Description

At the moment the latest AMI is read at deploy time. But to get an immutable infrastructure we have to fix the AMI. This PR adds variables to set the AMI id.

@kayman-mk kayman-mk requested a review from npalm as a code owner December 5, 2024 08:26
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.35s
✅ REPOSITORY checkov yes no 24.9s
✅ REPOSITORY dustilock yes no 0.18s
✅ REPOSITORY gitleaks yes no 0.7s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.59s
✅ REPOSITORY secretlint yes no 0.67s
✅ REPOSITORY syft yes no 1.29s
✅ REPOSITORY trivy-sbom yes no 0.07s
✅ REPOSITORY trufflehog yes no 3.39s
✅ SPELL cspell 5 0 2.31s
✅ TERRAFORM terraform-fmt 4 0 0 0.35s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@kayman-mk kayman-mk merged commit 7f47bdb into main Dec 5, 2024
18 checks passed
@kayman-mk kayman-mk deleted the kayma/add-ami-id branch December 5, 2024 09:07
kayman-mk pushed a commit that referenced this pull request Dec 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[8.1.0](8.0.1...8.1.0)
(2024-12-05)


### Features

* add variables to specify the AMI ids
([#1214](#1214))
([7f47bdb](7f47bdb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant