hello_schema: replace TempFile with TempDir #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennwc
reviewed
Apr 17, 2018
examples/hello_schema/main.go
Outdated
| checkErr(err) | ||
|
|
||
| defer os.Remove(tmpfile.Name()) // clean up | ||
| defer os.Remove(tmpdir) // clean up |
If TempFile is used cayley.NewGraph complains about tmpfile.Name() not being a dir.
mguentner
force-pushed
the
fix_hello_schema_example
branch
from
c92d4f7
to
e568dca
Compare
|
For the record, |
|
Seems so. It would be great if you could send the change for it as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If TempFile is used cayley.NewGraph complains about
tmpfile.Name() not being a dir.