Add NamesOf to the BatchQuadStore interface #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennwc
requested changes
Oct 18, 2018
graph/quadstore.go
Outdated
| @@ -31,7 +31,8 @@ import ( | |||
| ) | |||
|
|
|||
| type BatchQuadStore interface { | |||
| ValuesOf(ctx context.Context, vals []Value) ([]quad.Value, error) | |||
| ValuesOf(ctx context.Context, vals []Value) ([]quad.Value, error) // TODO: Should be called NamesOf() | |||
| NamesOf(ctx context.Context, nodes []quad.Value) ([]Value, error) // TODO: Should be called ValuesOf() | |||
There was a problem hiding this comment.
Suggested change
| NamesOf(ctx context.Context, nodes []quad.Value) ([]Value, error) // TODO: Should be called ValuesOf() | |
| RefsOf(ctx context.Context, nodes []quad.Value) ([]Value, error) // TODO: Should be called ValuesOf() |
And the ValuesOf above is fine. This is a legacy from an old version of Cayley. NameOf and ValueOf will be removed in v0.8.
graph/kv/quadstore.go
Outdated
| @@ -272,6 +272,16 @@ func (qs *QuadStore) ValuesOf(ctx context.Context, vals []graph.Value) ([]quad.V | |||
| } | |||
| return out, last | |||
| } | |||
|
|
|||
| // TODO: Proper BatchQuadStore support for this function | |||
There was a problem hiding this comment.
May I ask you to implement it at least partially? :)
Check the ValueOf, an algorithm is quite simple: open View once, iterate over values inside, call resolveQuadValue for each and store the result. But instead of dropping an error as ValueOf does, return it here.
graph/quadstore.go
Outdated
| @@ -45,6 +46,17 @@ func ValuesOf(ctx context.Context, qs QuadStore, vals []Value) ([]quad.Value, er | |||
| return out, nil | |||
| } | |||
|
|
|||
| func NamesOf(ctx context.Context, qs QuadStore, nodes []quad.Value) ([]Value, error) { | |||
There was a problem hiding this comment.
Suggested change
| func NamesOf(ctx context.Context, qs QuadStore, nodes []quad.Value) ([]Value, error) { | |
| func RefsOf(ctx context.Context, qs QuadStore, nodes []quad.Value) ([]Value, error) { |
phyrwork
force-pushed
the
batch-qs-namesof
branch
from
297f6ca
to
54d8874
Compare
Implement for kv/QuadStore to avoid breaking it's BatchQuadStore implementation.
phyrwork
force-pushed
the
batch-qs-namesof
branch
from
54d8874
to
b378435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement exposed by #741
Add NamesOf to the BatchQuadStore interface.
Add notes that NamesOf and ValuesOf have their names the wrong
way around.
Add a dummy NamesOf to kv/QuadStore to avoid breaking it's
BatchQuadStore implementation.