Fix test and example build warnings on stable Rust #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cberner
force-pushed
the
fix-warnings
branch
from
a7a5221 to
a5d8883
Compare
|
Thanks for promptly reviewing the last few PRs! |
github-merge-queue bot
pushed a commit
to awslabs/mountpoint-s3
that referenced
this pull request
Nov 22, 2024
This change pulls in the current state of our fuser fork, recently rebased on the latest commits upstream. Most importantly, we want to tackle build warnings which should be resolved by cberner/fuser#315. ### Does this change impact existing behavior? No, build warning fixes only. ### Does this change need a changelog entry? No, no API or behavior change. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
|
np :) Thanks for the improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses remaining build warnings on Rust toolchain v1.82. This is a follow-up change from #314, but tackles warnings in examples and tests.
To test, I ran the following using cargo-hack to check all examples and tests compile without warnings:
cargo +stable hack test --no-run --each-feature info: running `cargo test --no-run --all-features` on fuser (1/29) Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser) Finished `test` profile [unoptimized + debuginfo] target(s) in 0.89s Executable unittests src/lib.rs (target/debug/deps/fuser-19a359d13b46cf93) Executable tests/integration_tests.rs (target/debug/deps/integration_tests-026e89ffd72c4a5e)info: running
cargo test --no-run --no-default-featureson fuser (2/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 2.36sExecutable unittests src/lib.rs (target/debug/deps/fuser-3dece279defdbcff)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-dfccd4809f6abe77)
info: running
cargo test --no-run --no-default-features --features abi-7-10on fuser (3/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 2.36sExecutable unittests src/lib.rs (target/debug/deps/fuser-7947f2b23c31867b)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-40fa1addb0797e3f)
info: running
cargo test --no-run --no-default-features --features abi-7-11on fuser (4/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 2.69sExecutable unittests src/lib.rs (target/debug/deps/fuser-c28692db34cd265c)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-02f1620dca0f11bc)
info: running
cargo test --no-run --no-default-features --features abi-7-12on fuser (5/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 3.62sExecutable unittests src/lib.rs (target/debug/deps/fuser-6d785e8175cb6036)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-0f972000ebab9c47)
info: running
cargo test --no-run --no-default-features --features abi-7-13on fuser (6/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.27sExecutable unittests src/lib.rs (target/debug/deps/fuser-0b50e51e22b0e58b)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-3134b0f1d7c387e0)
info: running
cargo test --no-run --no-default-features --features abi-7-14on fuser (7/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.32sExecutable unittests src/lib.rs (target/debug/deps/fuser-e8813b32a52bea3b)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-3ca93b89a4c80cc3)
info: running
cargo test --no-run --no-default-features --features abi-7-15on fuser (8/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.55sExecutable unittests src/lib.rs (target/debug/deps/fuser-23e7822cdd44e8ce)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-06a92f81cbe8381c)
info: running
cargo test --no-run --no-default-features --features abi-7-16on fuser (9/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.88sExecutable unittests src/lib.rs (target/debug/deps/fuser-9dc0865ce9244aa0)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-5b107b72923de1f8)
info: running
cargo test --no-run --no-default-features --features abi-7-17on fuser (10/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.94sExecutable unittests src/lib.rs (target/debug/deps/fuser-c812d0319955be99)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-1942218f67510bec)
info: running
cargo test --no-run --no-default-features --features abi-7-18on fuser (11/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.87sExecutable unittests src/lib.rs (target/debug/deps/fuser-2f5161b88fffc89b)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-718ec1aeca5c84bd)
info: running
cargo test --no-run --no-default-features --features abi-7-19on fuser (12/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.57sExecutable unittests src/lib.rs (target/debug/deps/fuser-407cda202823333f)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-921d43eb8d1da8ad)
info: running
cargo test --no-run --no-default-features --features abi-7-20on fuser (13/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 6.10sExecutable unittests src/lib.rs (target/debug/deps/fuser-723d0103d62dcbf4)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-b50118d5d473f43a)
info: running
cargo test --no-run --no-default-features --features abi-7-21on fuser (14/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.75sExecutable unittests src/lib.rs (target/debug/deps/fuser-86d2c47e3749dfb6)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-a048ce04248f716a)
info: running
cargo test --no-run --no-default-features --features abi-7-22on fuser (15/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.69sExecutable unittests src/lib.rs (target/debug/deps/fuser-8cb29cbd67c4fce8)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-bf690458ab8c45bb)
info: running
cargo test --no-run --no-default-features --features abi-7-23on fuser (16/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.90sExecutable unittests src/lib.rs (target/debug/deps/fuser-1d740218a4771e2d)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-607f7fa4f34baaf9)
info: running
cargo test --no-run --no-default-features --features abi-7-24on fuser (17/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.74sExecutable unittests src/lib.rs (target/debug/deps/fuser-9aacb8f542a34eb8)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-58126e870edd657b)
info: running
cargo test --no-run --no-default-features --features abi-7-25on fuser (18/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.71sExecutable unittests src/lib.rs (target/debug/deps/fuser-1f497047b00de003)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-5ca201f211f4c261)
info: running
cargo test --no-run --no-default-features --features abi-7-26on fuser (19/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 6.02sExecutable unittests src/lib.rs (target/debug/deps/fuser-671f7dc4eaf42d14)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-8e47343970b132f1)
info: running
cargo test --no-run --no-default-features --features abi-7-27on fuser (20/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.94sExecutable unittests src/lib.rs (target/debug/deps/fuser-d246bdb2a3ac481e)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-dd3f0357f7b323f2)
info: running
cargo test --no-run --no-default-features --features abi-7-28on fuser (21/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.96sExecutable unittests src/lib.rs (target/debug/deps/fuser-43982a01c6f5ff38)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-488398e8cb00ee18)
info: running
cargo test --no-run --no-default-features --features abi-7-29on fuser (22/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.92sExecutable unittests src/lib.rs (target/debug/deps/fuser-02c681f29037fcf0)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-c7af7f9549d9edec)
info: running
cargo test --no-run --no-default-features --features abi-7-30on fuser (23/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 5.83sExecutable unittests src/lib.rs (target/debug/deps/fuser-7ef1c9bb55dfd728)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-81a6ac1ae8198bb7)
info: running
cargo test --no-run --no-default-features --features abi-7-31on fuser (24/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 6.04sExecutable unittests src/lib.rs (target/debug/deps/fuser-66221c2a7c2b4b95)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-7a08c7ca9b9f5549)
info: running
cargo test --no-run --no-default-features --features abi-7-9on fuser (25/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 4.30sExecutable unittests src/lib.rs (target/debug/deps/fuser-363c86e49135dd69)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-9efa26a9ac3801b7)
info: running
cargo test --no-run --no-default-features --features defaulton fuser (26/29)Finished
testprofile [unoptimized + debuginfo] target(s) in 0.05sExecutable unittests src/lib.rs (target/debug/deps/fuser-5a46633bcb5cdafb)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-fc6733877cbad737)
info: running
cargo test --no-run --no-default-features --features libfuseon fuser (27/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 4.02sExecutable unittests src/lib.rs (target/debug/deps/fuser-153a16339afde52b)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-4d17f365d69d30dc)
info: running
cargo test --no-run --no-default-features --features macfuse-4-compaton fuser (28/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 4.24sExecutable unittests src/lib.rs (target/debug/deps/fuser-672c5b71d91fb804)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-7c650737291f713f)
info: running
cargo test --no-run --no-default-features --features serializableon fuser (29/29)Compiling fuser v0.15.0 (/local/home/djonesoa/devel/fuser)
Finished
testprofile [unoptimized + debuginfo] target(s) in 4.36sExecutable unittests src/lib.rs (target/debug/deps/fuser-fb3cee2950586cf7)
Executable tests/integration_tests.rs (target/debug/deps/integration_tests-22d17e8f9ef58304)
This also identified that the features for one example were not sufficient, and this has now been fixed.