Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cloud voices on apple #1399

Merged
merged 5 commits into from
Mar 3, 2023

Conversation

tomivm
Copy link
Collaborator

@tomivm tomivm commented Mar 3, 2023

@tomivm tomivm requested a review from martinbedouret March 3, 2023 17:08
@tomivm tomivm self-assigned this Mar 3, 2023
src/constants.js Outdated
@@ -31,3 +31,8 @@ export const ADTEST_AVAILABLE =
export const ADSENSE_CLIENT = 'ca-pub-7162313874228987';

export const ADD_SLOT_SETTINGS_TOP = '5250438005';

export const IS_BROWSING_FROM_APPLE = (() => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think thath you can do directly like this: export const IS_BROWSING_FROM_APPLE =/iPad|iPhone|iPod|Mac/.test(navigator.userAgent)

@martinbedouret martinbedouret added this to the 1.26.0 milestone Mar 3, 2023
@martinbedouret martinbedouret merged commit 4b76fdb into cboard-org:master Mar 3, 2023
@martinbedouret martinbedouret linked an issue Mar 3, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloud voices not work on IOS Apple devices
3 participants