Fix/Output bar on Ios #1406
Merged
Fix/Output bar on Ios #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const scrollToLastSymbol = () => { | ||
| const { symbols } = this.props; | ||
| if (prevProps.symbols.length < symbols.length) { | ||
| try { |
There was a problem hiding this comment.
@martinbedouret What do you think about use try catch block here?
There was a problem hiding this comment.
maybe necessary for the case that element is not found?
There was a problem hiding this comment.
Yes. That was the intention.
martinbedouret
requested changes
Mar 9, 2023
| const scrollToLastSymbol = () => { | ||
| const { symbols } = this.props; | ||
| if (prevProps.symbols.length < symbols.length) { | ||
| try { |
There was a problem hiding this comment.
maybe necessary for the case that element is not found?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to create a global solution for all browsers and user agents. This fix implements a new way to auto-scroll to the output bar's last symbol.
close #1397