Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a try catch block in every use of FirebasePlugin #1554

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Add a try catch block in every use of FirebasePlugin #1554

merged 1 commit into from
Jul 28, 2023

Conversation

tomivm
Copy link
Collaborator

@tomivm tomivm commented Jul 25, 2023

This prevents a crash of the app if FirebasePlugin is undefined.

@tomivm tomivm added the bug label Jul 25, 2023
@tomivm tomivm requested a review from martinbedouret July 25, 2023 02:11
@tomivm tomivm self-assigned this Jul 25, 2023
@martinbedouret martinbedouret added this to the 1.31.0 milestone Jul 27, 2023
@martinbedouret martinbedouret merged commit 5174f05 into cboard-org:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbedouret martinbedouret martinbedouret approved these changes

Assignees

@tomivm tomivm

Labels
bug
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tomivm @martinbedouret