Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dialogs behind keyboard on Android and IOS #1557

Conversation

tomivm
Copy link
Collaborator

@tomivm tomivm commented Jul 31, 2023

This PR uses a newly added plugin to adjust welcome dialog sizes to not be covered by the keyboard on Android and IOS. Please @RodriSanchez1 can you Test it? Also, please use the keyboard with live mode to make sure the board is not resized.

Copy link
Collaborator

@RodriSanchez1 RodriSanchez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a good feature! I like it a lot!

src/components/WelcomeScreen/WelcomeScreen.container.js Outdated Show resolved Hide resolved
src/components/WelcomeScreen/WelcomeScreen.container.js Outdated Show resolved Hide resolved
@RodriSanchez1
Copy link
Collaborator

Suggestion:

  • Add an scroll indicator on sign up dialog. Needs to scroll to see the action buttons!
    Image on Samsung Galaxy Tab A7
    Screenshot_20230802-205517_AAC_Cboard 1

  • Smartphones will have problems on rotated screen. But i think this is not a big problem, we can avoid it. See:

Screenshot_20230802_205032_AAC Cboard

Copy link
Collaborator

@martinbedouret martinbedouret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomivm Please review comments from rodri

@martinbedouret martinbedouret merged commit ec6ad2e into cboard-org:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dialogs should shrink and positioned on the top of the screen when keyboard is open (android)
3 participants