Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Android Google logout #1639

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix - Android Google logout #1639

merged 2 commits into from
Dec 13, 2023

Conversation

RodriSanchez1
Copy link
Collaborator

On this PR:

  • Use new method window.FirebasePlugin.unregister();
  • Move GOOGLE_FIREBASE_WEB_CLIENT_ID to constants file. Also the constant name was changed

close #1637

@RodriSanchez1 RodriSanchez1 requested a review from tomivm December 13, 2023 21:55
@RodriSanchez1 RodriSanchez1 added this to the 1.33.0 milestone Dec 13, 2023
@tomivm tomivm merged commit 078a075 into cboard-org:master Dec 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivm tomivm tomivm approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.33.0
Development

Successfully merging this pull request may close these issues.

Fix logout
2 participants
@RodriSanchez1 @tomivm