Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alice-open-data: Replace deprecated env::home_dir with dirs crate #4

Merged
merged 1 commit into from
Dec 20, 2018
Merged

alice-open-data: Replace deprecated env::home_dir with dirs crate #4

merged 1 commit into from
Dec 20, 2018

Conversation

akubera
Copy link
Contributor

@akubera akubera commented Dec 20, 2018

Rust 1.29 deprecated the env::home_dir function and, in the compiler-warning, suggests replacing it with the dirs crate. This PR does that.

@cbourjau cbourjau self-requested a review December 20, 2018 15:35
cbourjau
cbourjau approved these changes Dec 20, 2018
View reviewed changes
Copy link
Owner

@cbourjau cbourjau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thank you very much for updating these bits!

@cbourjau cbourjau merged commit 8b425c2 into cbourjau:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbourjau cbourjau cbourjau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akubera @cbourjau