iter

cbuescher · Oct 30, 2023 · f1027e9 · f1027e9
1 parent fbffc2f
commit f1027e9
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/server/src/test/java/org/elasticsearch/search/suggest/SuggestTests.java b/server/src/test/java/org/elasticsearch/search/suggest/SuggestTests.java
@@ -247,9 +247,9 @@ public void testSerialization() throws IOException {
         );
 
         final Suggest suggest = createTestItem();
-        // if bwc version is below V_8_8_0 we need to make sure potential
-        // search hits in CompletionSuggestion$Entry$Option don't have "rank" set
-        // TODO remove this once MINIMUM_COMPATIBLE > V_8_8_0
+        // suggest is disallowed when using rank, but the randomization rarely sets it
+        // we need to make sure CompletionSuggestion$Entry$Option doesn't have "rank" set
+        // because for some older versions it will not serialize.
         if (bwcVersion.before(TransportVersions.V_8_8_0)) {
             for (CompletionSuggestion s : suggest.filter(CompletionSuggestion.class)) {
                 for (CompletionSuggestion.Entry entry : s.entries) {