Skip to content

Commit

Permalink
Improve error handling and user options for SRT creation
Browse files Browse the repository at this point in the history
Refactor message box for SRT creation errors, adding distinct buttons for skipping all subtitles or continuing on errors, and update processing logic accordingly.
  • Loading branch information
cbusillo committed Jul 4, 2024
1 parent 1772fed commit 8a839f9
Showing 1 changed file with 17 additions and 9 deletions.
26 changes: 17 additions & 9 deletions bd_to_avp/gui/main_window.py
Original file line number Diff line number Diff line change
Expand Up @@ -322,20 +322,28 @@ def handle_file_exists_error(self, error: FileExistsError) -> None:

def handle_srt_creation_error(self, error: SRTCreationError) -> None:
self.notify_user_with_sound("Sosumi")
result = QMessageBox.critical(
self,
message_box = QMessageBox(
QMessageBox.Icon.Critical,
"",
"SRT Creation Error\n\nDo you want to continue?\n\n" + str(error),
QMessageBox.StandardButton.Yes | QMessageBox.StandardButton.Abort,
"SRT Creation Error\n\nDo you want to skip all subsequent subtitles?\n\n" + str(error),
QMessageBox.StandardButton.Abort,
)
skip_button = message_box.addButton("Skip All Subtitles", QMessageBox.ButtonRole.YesRole)
continue_button = message_box.addButton("Continue On Errors", QMessageBox.ButtonRole.NoRole)

if result == QMessageBox.StandardButton.Yes:
config.skip_subtitles = True
config.start_stage = Stage.CREATE_LEFT_RIGHT_FILES
self.start_processing(is_continuing=True)
result = message_box.exec()

if result == QMessageBox.StandardButton.Abort:
self.handle_processing_error(error)
return

self.handle_processing_error(error)
if message_box.clickedButton() == skip_button:
config.skip_subtitles = True
elif message_box.clickedButton() == continue_button:
config.continue_on_error = True

config.start_stage = Stage.CREATE_LEFT_RIGHT_FILES
self.start_processing(is_continuing=True)

def toggle_read_from_disc(self) -> None:
self.source_folder_widget.setEnabled(not self.read_from_disc_checkbox.isChecked())
Expand Down

0 comments on commit 8a839f9

Please sign in to comment.