Fix for cloudflare verification issue #3416
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allowing blob: would make this feature pointless as it would also allow the obnoxious ad scripts that were the reason this was introduced in the first place. Since I haven't heard many reports of those lately, I think it's better to just disable the feature by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3407
The issue was that 4chanx's JS Whitelist functionality blocks any type of "blob:" url, one of which is used briefly in Cloudflare's code. Once that was handled, challenges.cloudflare.com was found to be blocked as well. By adding blobs and the challenges domain to the whitelist, the cloudflare verification check proceeds without problems.
The code compiles and was tested to work by enabling the plugin, clearing the cloudflare cookies on 4chan.org, then reloading the page to see the cloudflare verification page appear and redirect successfully. Testing was done in Chrome 118.0.5993.89 on Win 10.