Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs clarity #41

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Docs clarity #41

merged 3 commits into from
Feb 4, 2021

Conversation

snide
Copy link

@snide snide commented Feb 4, 2021

Some docs stuff. Mostly making the top example more clear and better defining the titles so they better describe when they show components vs. full layouts.

Copy link
Owner

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was going to progress upward through the page components updating the docs as I go which is why I intentionally didn't touch the other examples for now. But we can add now and continue to update too.

I've made review comments, but I'll apply them all.

src-docs/src/views/page/page.js Outdated Show resolved Hide resolved
src-docs/src/views/page/page_example.js Outdated Show resolved Hide resolved
src-docs/src/views/page/page_example.js Outdated Show resolved Hide resolved
src-docs/src/views/page/page_example.js Outdated Show resolved Hide resolved
src-docs/src/views/page/page_example.js Outdated Show resolved Hide resolved
src-docs/src/views/page/page_example.js Outdated Show resolved Hide resolved
src-docs/src/views/page/page_example.js Outdated Show resolved Hide resolved
src-docs/src/views/page/page_example.js Outdated Show resolved Hide resolved
src-docs/src/views/page/page_example.js Outdated Show resolved Hide resolved
src-docs/src/views/page/page_example.js Outdated Show resolved Hide resolved
@cchaos cchaos merged commit 7dec3f6 into cchaos:props/page_header Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants