Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some REPL history improvements #20

Closed
wants to merge 5 commits into from
Closed

Some REPL history improvements #20

wants to merge 5 commits into from

Conversation

guv
Copy link

@guv guv commented Dec 15, 2012

I made some small changes to the REPL history:

  • Namespace switching comments are not included in the REPL history anymore.
  • Preferences for REPL history: (1) maximum history size and (2) persistence schedule

@guv
Copy link
Author

guv commented Jan 13, 2013

Oh, github deleted your comments when I pushed the rebased branch forcefully. :/
I fixed the function naming and removed the redundant javadoc.

To your last comment:
This branch does not change the way "quiet mode" and "non-quiet mode" work:
In the REPL the namespace switching is displayed in "non-quiet mode" but it is not logged to the REPL history anymore.
There is no use writing those comments to the history, is there?
On the contrary it is pretty annoying to encounter multiple comments when browsing back through the history.

@laurentpetit
Copy link
Member

That's right !

Le dimanche 13 janvier 2013, Gunnar Völkel a écrit :

Oh, github deleted your comments when I pushed the rebased branch
forcefully. :/
I fixed the function naming and removed the redundant javadoc.

To your last comment:
This branch does not change the way "quiet mode" and "non-quiet mode" work:
In the REPL the namespace switching is displayed in "non-quiet mode" but
it is not logged to the REPL history anymore.
There is no use writing those comments to the history, is there?
On the contrary it is pretty annoying to encounter multiple comments when
browsing back through the history.


Reply to this email directly or view it on GitHubhttps://github.com//pull/20#issuecomment-12194276.

ClojurePreferencePage_description=Expand the tree to edit preferences for a specific feature.
ClojurePreferencePage_displayed_tab_width=Displayed tab width:
ClojurePreferencePage_highlight_matching_brackets=Highlight &matching brackets
ClojurePreferencePage_switch_to_ns_on_repl_startup=On file launch, switch the Repl to the file namespace (calling 'in-ns)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I accidental change that?

@guv
Copy link
Author

guv commented Aug 8, 2013

I rebased this branch to the current ccw master.

@laurentpetit
Copy link
Member

manually integrated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants