-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👷 update framework #367
👷 update framework #367
Conversation
The currently thrown errors |
Alright. Given that this is supposedly fixed in 1.2.1, the easiest fix would be to exclude the 1.2.0 release here, I.e.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
=======================================
+ Coverage 92.0% 93.0% +0.9%
=======================================
Files 48 48
Lines 2466 2426 -40
=======================================
- Hits 2270 2257 -13
+ Misses 196 169 -27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this. Just did a very quick review and left some comments. Hopefully shouldn't take too long to incorporate. Similar feedback probably also applies to the predictor PR.
Co-authored-by: Lukas Burgholzer <burgholzer@me.com> Signed-off-by: Nils Quetschlich <nils.quetschlich@tum.de>
Co-authored-by: Lukas Burgholzer <burgholzer@me.com> Signed-off-by: Nils Quetschlich <nils.quetschlich@tum.de>
Co-authored-by: Lukas Burgholzer <burgholzer@me.com> Signed-off-by: Nils Quetschlich <nils.quetschlich@tum.de>
Co-authored-by: Lukas Burgholzer <burgholzer@me.com> Signed-off-by: Nils Quetschlich <nils.quetschlich@tum.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional changes! LGTM now ✅
This PR