Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡🚨 make qiskit_optimization import lazy #383

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Conversation

burgholzer
Copy link
Member

This PR slightly adjusts the imports in the utils.py file so that qiskit_optimization is important lazily.
Besides slightly improving the general import speed, this also avoids a docplex syntax warning appearing on Python 3.12+ when importing mqt.bench.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this Sep 19, 2024
@burgholzer burgholzer added python Pull requests that update Python code usability Anything related to usability mqt.bench Issues that affect mqt.bench labels Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.1%. Comparing base (d24e61d) to head (3442b82).
Report is 65 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #383   +/-   ##
=====================================
  Coverage   93.0%   93.1%           
=====================================
  Files         48      48           
  Lines       2438    2438           
=====================================
+ Hits        2269    2270    +1     
+ Misses       169     168    -1     
Flag Coverage Δ
python 93.1% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burgholzer burgholzer merged commit 0479d73 into main Sep 22, 2024
22 checks passed
@burgholzer burgholzer deleted the lazy-import branch September 22, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mqt.bench Issues that affect mqt.bench python Pull requests that update Python code usability Anything related to usability
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant