-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥Remove most of the qiskit application module benchmarks #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
they are effectively just randomly instantiated ansatz functions Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
before, this was implicit via qiskit-optimization Signed-off-by: burgholzer <burgholzer@me.com>
yet another RealAmplitudes ansatz under the hood Signed-off-by: burgholzer <burgholzer@me.com>
burgholzer
added
dependencies
Pull requests that update a dependency file
python
Pull requests that update Python code
major
Part of a major release
usability
Anything related to usability
mqt.bench
Issues that affect mqt.bench
labels
Oct 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
=======================================
- Coverage 92.8% 91.9% -0.9%
=======================================
Files 43 35 -8
Lines 1969 1647 -322
=======================================
- Hits 1828 1515 -313
+ Misses 141 132 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
this will be implemented as part of #429 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
major
Part of a major release
mqt.bench
Issues that affect mqt.bench
python
Pull requests that update Python code
usability
Anything related to usability
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes most of the qiskit application module benchmarks. The corresponding packages are hardly maintained and the corresponding benchmarks where simple ansatz functions that are available as part of MQT Bench anyways.
Based on the fact that hardly any optimization is being conducted as part of the generation process, these application benchmarks weren't that different from the basic ansatz function benchmarks.
This reduces the number of available benchmarks. At the same time, it considerably reduces the dependencies of MQT Bench.
Overall, this still marks a major breaking change in the benchmarks offered by MQT Bench.
Fixes #390