Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ try to make test suite pass despite third party problems #7

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

burgholzer
Copy link
Member

This PR experiments with (temporarily) disabling the "warnings are errors" setting for pytest until #3 is fixed. This should allow the test suite to run and coverage data to be uploaded.
This change should be reverted as soon as #3 is fixed.

@burgholzer burgholzer added continuous integration Anything related to the CI setup fix Fix for something that is not working labels Jun 7, 2024
@burgholzer burgholzer self-assigned this Jun 7, 2024
@burgholzer
Copy link
Member Author

Ok. This is a great start. Most of the jobs are passing.

The macOS failure is mostly due to Qiskit/qiskit-aer#2167, which should hopefully be resolved soonish.

@DeborahVolpe could you please check the Ubuntu Python 3.9 failure. One of the test assertions got triggered there.

@burgholzer
Copy link
Member Author

Ok, seems to be a flaky test.

https://github.com/cda-tum/mqt-qao/actions/runs/9415214314/job/25935789249?pr=7 passed, while https://github.com/cda-tum/mqt-qao/actions/runs/9414958125/job/25934945203 failed.
Seems like tests are not fully deterministic.

Copy link

codecov bot commented Jun 7, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@burgholzer
Copy link
Member Author

Nice, all tests run through and CI is green ✅ no more force merging PRs 🎉

@burgholzer burgholzer merged commit 4abcb6b into main Jun 7, 2024
22 checks passed
@burgholzer burgholzer deleted the make-tests-work branch June 7, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup fix Fix for something that is not working
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant