Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fix deprecation warnings related to qiskit-aer #103

Merged
merged 6 commits into from
Mar 31, 2023

Conversation

33Gjl1Xe
Copy link
Contributor

@33Gjl1Xe 33Gjl1Xe commented Mar 31, 2023

Description

Switches to Qiskit's simulator provider in favor of qiskit-aer to get rid of some deprecation warnings.

Fixes #66
Fixes #94

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added bug Something isn't working dependencies Pull requests that update a dependency file labels Mar 31, 2023
pyproject.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.1%. Comparing base (93548bc) to head (4787b2e).
Report is 244 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #103     +/-   ##
=======================================
- Coverage   84.2%   84.1%   -0.1%     
=======================================
  Files         18      18             
  Lines       1228    1226      -2     
  Branches     190     190             
=======================================
- Hits        1034    1032      -2     
  Misses       194     194             
Flag Coverage Δ
cpp 79.5% <ø> (ø)
python 96.6% <100.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burgholzer burgholzer changed the title Fix deprecated warnings 🩹 Fix deprecation warnings related to qiskit-aer Mar 31, 2023
@burgholzer burgholzer marked this pull request as ready for review March 31, 2023 13:10
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks. Looks much cleaner now.

@burgholzer burgholzer enabled auto-merge (squash) March 31, 2023 13:11
@burgholzer burgholzer merged commit 4aa3b91 into main Mar 31, 2023
@burgholzer burgholzer deleted the fix_deprecated_warning branch March 31, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 fix ECC framework tests 🐛 Solve the "PendingDeprecationWarning" when using Qiskit
2 participants