Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Simplify noise-aware simulation in ECC framework #119

Merged
merged 1 commit into from
May 16, 2023

Conversation

burgholzer
Copy link
Member

Description

This tiny PR simplifies some details in the ECC framework Qiskit wrapper.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@burgholzer burgholzer added the enhancement Enhancement to existing feature label May 16, 2023
@burgholzer burgholzer self-assigned this May 16, 2023
@burgholzer burgholzer enabled auto-merge (squash) May 16, 2023 10:18
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #119 (cdce7ef) into main (2dd7a17) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #119     +/-   ##
=======================================
- Coverage   85.6%   85.6%   -0.1%     
=======================================
  Files         20      20             
  Lines       1364    1362      -2     
  Branches     190     190             
=======================================
- Hits        1168    1166      -2     
  Misses       196     196             
Flag Coverage Δ
cpp 79.5% <ø> (ø)
python 97.2% <100.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mqt/qecc/ecc_qiskit_wrapper.py 97.8% <100.0%> (-0.1%) ⬇️

@burgholzer burgholzer merged commit c01fa39 into main May 16, 2023
@burgholzer burgholzer deleted the refactor-ecc-simulator branch May 16, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant