Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Analog information decoding #183

Merged
merged 130 commits into from
Dec 22, 2023
Merged

✨ Analog information decoding #183

merged 130 commits into from
Dec 22, 2023

Conversation

lucasberent
Copy link
Collaborator

@lucasberent lucasberent commented Nov 2, 2023

Description

This PR integrates the newest analog information decoding scripts.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 113 lines in your changes are missing coverage. Please review.

Comparison is base (d61ccab) 85.6% compared to head (88c7c99) 84.6%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #183     +/-   ##
=======================================
- Coverage   85.6%   84.6%   -1.0%     
=======================================
  Files         20      25      +5     
  Lines       1369    2020    +651     
  Branches     190     190             
=======================================
+ Hits        1172    1710    +538     
- Misses       197     310    +113     
Flag Coverage Δ
cpp 79.5% <ø> (ø)
python 88.6% <82.8%> (-8.4%) ⬇️
Files Coverage Δ
src/mqt/qecc/__init__.py 100.0% <100.0%> (ø)
src/mqt/qecc/cc_decoder/decoder.py 98.2% <100.0%> (ø)
src/mqt/qecc/cc_decoder/hexagonal_color_code.py 100.0% <100.0%> (ø)
src/mqt/qecc/ecc_qiskit_wrapper.py 97.8% <100.0%> (ø)
...mation_decoding/simulators/memory_experiment_v2.py 84.4% <84.4%> (ø)
...decoding/simulators/analog_tannergraph_decoding.py 90.0% <90.0%> (ø)
...log_information_decoding/utils/simulation_utils.py 86.9% <86.9%> (ø)
...mation_decoding/simulators/quasi_single_shot_v2.py 69.9% <69.9%> (ø)
...alog_information_decoding/simulators/simulation.py 82.2% <82.2%> (ø)

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some quick corrections.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@burgholzer burgholzer added feature New feature or request minor Minor version update labels Dec 18, 2023
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished some small cleanups. Brought all external dependencies up to date, enabled formatting for all files and linting for a couple more files than before.

I haven't really checked the code itself, but I have sufficient trust that it is doing what it intends to do. So once CI is happy, I'll go ahead and merge 🎉

@burgholzer burgholzer changed the title Analog information decoding ✨ Analog information decoding Dec 22, 2023
@burgholzer burgholzer merged commit 5c75bc0 into main Dec 22, 2023
27 of 29 checks passed
@burgholzer burgholzer deleted the analog-information-decoding branch December 22, 2023 16:29
@burgholzer burgholzer restored the analog-information-decoding branch December 22, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request minor Minor version update
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants