Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pybind version #215

Merged
merged 1 commit into from
Apr 21, 2024
Merged

update pybind version #215

merged 1 commit into from
Apr 21, 2024

Conversation

lucasberent
Copy link
Collaborator

@lucasberent lucasberent commented Apr 21, 2024

Description

This PR updates the minimum pybind11 version to 2.12, which was released a couple weeks ago and brings several big improvements, including compatibility with Numpy 2.0 which will be released soon, see cda-tum/mqt-qcec#383

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.7%. Comparing base (64d71a8) to head (71a6056).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #215   +/-   ##
=====================================
  Coverage   84.6%   84.7%           
=====================================
  Files         25      25           
  Lines       2023    2023           
  Branches     191     191           
=====================================
+ Hits        1713    1714    +1     
+ Misses       310     309    -1     
Flag Coverage Δ
cpp 79.5% <ø> (ø)
python 88.8% <ø> (+<0.1%) ⬆️

see 1 file with indirect coverage changes

@lucasberent lucasberent merged commit 63a8763 into main Apr 21, 2024
28 checks passed
@lucasberent lucasberent deleted the update-pybind branch April 21, 2024 12:40
@burgholzer burgholzer added packaging Anything related to Python packaging python Pull requests that update Python code labels Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Anything related to Python packaging python Pull requests that update Python code
Projects
Development

Successfully merging this pull request may close these issues.

2 participants