Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐍 Fix mapping for circuits with more than 128 qubits #519

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Sep 9, 2024

Description

Trying to map a circuit consisting of more than 128 qubits currently leads to an out-of-bounds exception being thrown.
This PR aims to address this issue.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this Sep 9, 2024
@burgholzer burgholzer added c++ Anything related to C++ code fix Anything related to bugfixes labels Sep 9, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer enabled auto-merge (squash) September 9, 2024 15:38
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.4%. Comparing base (e958822) to head (3b83d74).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
include/sc/Mapper.hpp 0.0% 2 Missing ⚠️
src/sc/Mapper.cpp 83.3% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #519   +/-   ##
=====================================
  Coverage   90.4%   90.4%           
=====================================
  Files         87      87           
  Lines      10050   10052    +2     
  Branches    1716    1722    +6     
=====================================
+ Hits        9090    9093    +3     
+ Misses       960     959    -1     
Flag Coverage Δ
cpp 90.1% <88.8%> (+<0.1%) ⬆️
python 95.9% <ø> (ø)
Files with missing lines Coverage Δ
include/sc/Architecture.hpp 88.5% <ø> (ø)
include/sc/DataLogger.hpp 100.0% <ø> (ø)
include/sc/heuristic/HeuristicMapper.hpp 100.0% <100.0%> (ø)
src/sc/DataLogger.cpp 90.7% <100.0%> (+0.4%) ⬆️
src/sc/heuristic/HeuristicMapper.cpp 96.9% <100.0%> (ø)
include/sc/Mapper.hpp 85.2% <0.0%> (ø)
src/sc/Mapper.cpp 92.6% <83.3%> (+0.2%) ⬆️

@burgholzer burgholzer merged commit 1170b3d into main Sep 9, 2024
32 of 33 checks passed
@burgholzer burgholzer deleted the debug-more-than-128-qubits branch September 9, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code fix Anything related to bugfixes
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant