Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg-config support for cddlib #40

Merged
merged 3 commits into from
Feb 10, 2020
Merged

pkg-config support for cddlib #40

merged 3 commits into from
Feb 10, 2020

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Feb 8, 2020

also, checking that gmp header is present, not only library

@dimpase
pkg-config support for cddlib
c444bb8 
also, checking that gmp header is present, not only library
@dimpase dimpase mentioned this pull request Feb 8, 2020
Closed
@dimpase
Copy link
Member Author

dimpase commented Feb 8, 2020

I've added AC_CHECK_HEADER for gmp.h, without it make might fail if there are no headers, only the libraries

saraedum
saraedum approved these changes Feb 8, 2020
View reviewed changes
Copy link
Member

@saraedum saraedum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If no one else has any additions, I'll merge this.

configure.ac Outdated Show resolved Hide resolved
@dimpase @saraedum
improving the comment
c3743e0 
Co-Authored-By: Julian Rüth <julian.rueth@fsfe.org>
@saraedum saraedum merged commit a139849 into cddlib:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saraedum saraedum saraedum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimpase @saraedum