@trivial minor fixes suggested in review. Iteration #1.

cdegroot-adobe · Mar 29, 2018 · e04cd20 · e04cd20
1 parent ac9024e
commit e04cd20
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 37 deletions.
diff --git a/extensions/adobe/experience/campaign/experienceevent.example.click.json b/extensions/adobe/experience/campaign/experienceevent.example.click.json
@@ -44,7 +44,7 @@
     "proofMember": false,
     "controlGroupMember": false,
     "testMember": true,
-    "ip": "10.20.30.40",
+    "outboundIP": "10.20.30.40",
     "offerProposed": [
       {
         "id": 1234,
@@ -78,7 +78,7 @@
     "from": "no-reply@adobe.com",
     "testEnabled": true,
     "messageClass": "messageCenter",
-    "template": 1100
+    "templateID": 1100
   },
   "https://ns.adobe.com/experience/campaign/link": {
     "id": "98765",

diff --git a/extensions/adobe/experience/campaign/experienceevent.example.email-send.json b/extensions/adobe/experience/campaign/experienceevent.example.email-send.json
@@ -34,7 +34,7 @@
     "controlGroupMember": false,
     "testMember": true,
     "size": 421,
-    "ip": "10.20.30.40",
+    "outboundIP": "10.20.30.40",
     "offerProposed": [
       {
         "id": 1234,
@@ -60,7 +60,7 @@
     "from": "no-reply@adobe.com",
     "testEnabled": true,
     "messageClass": "continuous",
-    "template": 1000
+    "templateID": 1000
   },
   "https://ns.adobe.com/experience/campaign/id": 100,
   "externalId": "uuid:00112233-4455-6677-8899-AABBCCDDEEFF",

diff --git a/extensions/adobe/experience/campaign/experienceevent.example.open-push.json b/extensions/adobe/experience/campaign/experienceevent.example.open-push.json
@@ -46,33 +46,14 @@
     "quarantine": false,
     "proofMember": false,
     "controlGroupMember": false,
-    "testMember": true,
-    "ip": "10.20.30.40",
-    "offerProposed": [
-      {
-        "id": 1234,
-        "name": "50-percent-off",
-        "activityId": 1357,
-        "activityName": "major-banner",
-        "placementId": 2,
-        "placementName": "top"
-      },
-      {
-        "id": 1235,
-        "name": "bogo",
-        "activityId": 1357,
-        "activityName": "major-banner",
-        "placementId": 3,
-        "placementName": "sidebar"
-      }
-    ]
+    "testMember": false
   },
   "https://ns.adobe.com/experience/campaign/delivery": {
     "id": 1001,
     "channel": "https://ns.adobe.com/xdm/channels/apns",
     "testEnabled": false,
     "messageClass": "messageCenter",
-    "template": 1100
+    "templateID": 1100
   },
   "externalId": "uuid:00112233-4455-6677-8899-AABBCCDDEEFF",
   "businessContext": "store-entry-beacon-triggered"

diff --git a/extensions/adobe/experience/campaign/experienceevent.schema.json b/extensions/adobe/experience/campaign/experienceevent.schema.json
@@ -77,7 +77,7 @@
         },
         "https://ns.adobe.com/experience/campaign/message/reason": {
           "title": "Reason",
-          "type": "integer",
+          "type": "string",
           "meta:enum": {
             "Undefined": "Not defined",
             "UnknownUser": "User unknown",
@@ -114,8 +114,9 @@
           "description":
             "Reason of message delivery failure when the status is `bounce` or `nonDeliverable`."
         },
-        "https://ns.adobe.com/experience/campaign/message/ip": {
+        "https://ns.adobe.com/experience/campaign/message/outboundIP": {
           "title": "IP Address",
+          "type": "string",
           "oneOf": [
             {
               "format": "ipv4"
@@ -169,7 +170,7 @@
         },
         "https://ns.adobe.com/experience/campaign/delivery/messagesClass": {
           "title": "Message Class",
-          "type": "integer",
+          "type": "string",
           "meta:enum": {
             "oneTime": "Marketing (One Time)",
             "continuous": "Recurring",
@@ -179,11 +180,11 @@
             "Marketing classification of the messages sent through that delivery.\n",
           "default": 0
         },
-        "https://ns.adobe.com/experience/campaign/delivery/template": {
+        "https://ns.adobe.com/experience/campaign/delivery/templateID": {
           "title": "Template",
           "type": "integer",
           "description":
-            "The delivery template used to initialize this delivery.\n\nThe type the template used in Adobe Campaign can be identified using the `messageClass`.\n\n* `messageClass` = `oneTime`: the template is standard delivery template.\n* `messageClass` = `continuous`: the template is a recurring delivery.\n* `messageClass` = `transactional`: the template is a transactionnal message template.\n"
+            "The delivery template's ID used to initialize this delivery.\n\nThe type the template used in Adobe Campaign can be identified using the `messageClass`.\n\n* `messageClass` = `oneTime`: the template is standard delivery template.\n* `messageClass` = `continuous`: the template is a recurring delivery.\n* `messageClass` = `transactional`: the template is a transactionnal message template.\n"
         },
         "https://ns.adobe.com/experience/campaign/link/id": {
           "title": "Tracking URL ID",
@@ -239,13 +240,13 @@
           "title": "External ID",
           "type": "string",
           "description":
-            "An ID generated by Voyager for a message to check later if the incoming experienceEvent was generated from this ID."
+            "An ID generated by the parent activity invoking service to check later if the incoming experienceEvent was generated using this ID."
         },
         "https://ns.adobe.com/experience/campaign/businessContext": {
           "title": "Business Context",
           "type": "string",
           "description":
-            "Internal field for identifying the various actions/intents from Voyager."
+            "Internal field for identifying the various actions/intents."
         }
       }
     }

diff --git a/extensions/adobe/experience/campaign/offer.schema.json b/extensions/adobe/experience/campaign/offer.schema.json
@@ -7,17 +7,17 @@
   ],
   "$id": "https://ns.adobe.com/xdm-extensions/adobe/experience/campaign/offer",
   "$schema": "http://json-schema.org/draft-06/schema#",
-  "title": "Offer Placement",
+  "title": "Offer",
   "type": "object",
   "description":
-    "The Offer Placement represents the instance of an offer displayed in a message.",
+    "This represents the instance of an offer displayed in a message.",
   "definitions": {
     "offer": {
       "properties": {
         "https://ns.adobe.com/experience/campaign/offer/id": {
           "title": "Offer ID",
           "type": "integer",
-          "description": "Unique identifier of the offer.",
+          "description": "Identifier of the offer.",
           "minimum": 0,
           "maximum": 2147483647
         },
@@ -30,7 +30,7 @@
           "title": "Activity ID",
           "type": "integer",
           "description":
-            "Unique identifier of the offer activity in the Offer Service.",
+            "Identifier of the offer activity in the Offer Service.",
           "minimum": 0,
           "maximum": 2147483647
         },
@@ -42,7 +42,7 @@
         "https://ns.adobe.com/experience/campaign/offer/placementId": {
           "title": "Placement ID",
           "type": "integer",
-          "description": "Unique identifier of the placement of the offer.",
+          "description": "Identifier of the placement of the offer.",
           "minimum": 0,
           "maximum": 2147483647
         },