Make use of unsafe yaml forward compatible #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The forthcoming 5.x release of PyYMAL changes how unsafe yaml is managed [1]. The default for gabbi is to safe load but the option has been present to unsafe load if code-executing functionality was desired. The way to achieve that in 5.x and beyond is more explicit than prior versions. In this change we adjust the unsafe loading to work with both 3.x and the as yet unreleased 5.x. Fixes #266 [1] https://msg.pyyaml.org/load
sileht
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forthcoming 5.x release of PyYMAL changes how unsafe
yaml is managed [1]. The default for gabbi is to safe
load but the option has been present to unsafe load if
code-executing functionality was desired. The way to
achieve that in 5.x and beyond is more explicit than
prior versions.
In this change we adjust the unsafe loading to work with
both 3.x and the as yet unreleased 5.x.
Fixes #266
[1] https://msg.pyyaml.org/load