-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Github-CDEvents Integration #47
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: airghy <tchuinkoufongue@gmail.com>
Signed-off-by: airghy <tchuinkoufongue@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, I left a few comments.
Let me know what you think. The idea in cdevents/webhook-adapter#2 is to create a plugin for the existing webhook adapter, not to create a new one. You could use the existing gerrit plugin as a starting point: https://github.com/cdevents/gerrit-translator/
Signed-off-by: airghy <tchuinkoufongue@gmail.com>
@afrittoli i have just modified the PR and tried to modify and simplify it as i could and got inspired by the https://github.com/cdevents/gerrit-translator/. Let me know what you think about. This could be a good starting point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I left a few comments, but generally it looks good.
Looking forward to see this implemented!
I went ahead and created the repo: https://github.com/cdevents/github-translator
@xibz FYI
Signed-off-by: airghy <tchuinkoufongue@gmail.com>
This RFC describes
an approach to integrate Jira with CDEvents using using webhook-adapter.
and the list of Github-Webhook event types mapping with CDEvents.
This RFC is related to this task cd-event-github-plugin