Fix custom data implementation #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afrittoli
force-pushed
the
custom_data_part2
branch
from
dbf2d6b
to
6ebc11c
Compare
Use a custom unmarshaller and jsonschema tags to fix
the implementation of custom data.
`CustomData` contains the data as follows:
When the content type is "application/json":
- if the CDEvent is produced via the golang API, the
`CustomData` usually holds an un-marshalled golang
interface{} of some type
- if the CDEvent is consumed and thus un-marshalled
from a []byte the `CustomData` holds the data as a
[]byte, so that it may be un-marshalled into a specific
golang type via the `GetCustomDataAs`
When the content type is anything else:
- the content data is always stored as []byte, as the
SDK does not have enough knowledge about the data to
un-marshal it into a golang type
Extend the interface to include GetCustomDataRaw which
always returns a []byte.
Extend the test coverage.
Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
afrittoli
force-pushed
the
custom_data_part2
branch
from
6ebc11c
to
ca9b92b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a custom unmarshaller and jsonschema tags to fix the implementation of custom data.
CustomDatacontains the data as follows:When the content type is "application/json":
CustomDatausually holds an un-marshalled golang interface{} of some typeCustomDataholds the data as a []byte, so that it may be un-marshalled into a specific golang type via theGetCustomDataAsWhen the content type is anything else:
Extend the interface to include GetCustomDataRaw which always returns a []byte.
Extend the test coverage.
Signed-off-by: Andrea Frittoli andrea.frittoli@gmail.com