fix: correct event go files generator shell script #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomnoise
force-pushed
the
fix-add-event-sh
branch
from
1968d99
to
5c4a149
Compare
afrittoli
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Thanks @randomnoise
In future we may create something that can deal with custom subject fields as well, but for now this is really helpful when adding new events.
As a follow up to this PR, perhaps we could document the need to update this file as part of SDK updates, or even have a CI job that checks that the modules create by this match with those in tree (at least to a certain degree).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #24.
When
./hack/add-events.sh && make fmtcommand is run, there are missing fields and functions in the newly generated files.With this PR, when the command is run, 14 .go files in
./pkg/apiare generated wihout any changes.The changes for the rest of files in the directory are mostly additional subject content fields, subject field setter functions and specific to each event.