Set the CloudEvent ID to match CDEvents Id #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the CloudEvent binding, the CloudEvent ID must match, according to the specification, with the CDEvents Id. This can be done today by the event producer via the CloudEvents and CDEvents SDKs, however, since it's required by the spec, it's better implemented as default by the CDEvents SDK directly. Fixes: cdevents#57 Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the CloudEvent binding, the CloudEvent ID must match, according to the specification, with the CDEvents Id.
This can be done today by the event producer via the CloudEvents and CDEvents SDKs, however, since it's required by the spec, it's better implemented as default by the CDEvents SDK directly.
Fixes: #57