Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom events #85

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

afrittoli
Copy link
Contributor

Add the ability to produce and consume custom events, including testing of the custom/conformance.json from the spec.

This does not include validation against customSchemaUri yet, that will be implemented as a separate feature as it applies to both regular and custom events.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 84.84848% with 95 lines in your changes missing coverage. Please review.

Project coverage is 82.29%. Comparing base (9ac1c56) to head (5bcada8).

Files Patch % Lines
tools/generator.go 37.06% 57 Missing and 16 partials ⚠️
pkg/api/zz_customtype_0_4_1.go 86.04% 10 Missing and 2 partials ⚠️
pkg/api/zz_ztest_foosubjectbarpredicate_1_2_3.go 0.00% 4 Missing ⚠️
pkg/api/v990/types.go 50.00% 1 Missing and 1 partial ⚠️
pkg/api/v991/types.go 50.00% 1 Missing and 1 partial ⚠️
pkg/api/zz_ztest_foosubjectbarpredicate_2_2_3.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   81.94%   82.29%   +0.35%     
==========================================
  Files         100      101       +1     
  Lines        7689     8028     +339     
==========================================
+ Hits         6301     6607     +306     
- Misses       1168     1196      +28     
- Partials      220      225       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afrittoli afrittoli force-pushed the custom_events branch 3 times, most recently from 4a594e9 to 5bcada8 Compare July 9, 2024 12:35
Add the ability to produce and consume custom events, including
testing of the custom/conformance.json from the spec.

This does not include validation against customSchemaUri yet,
that will be implemented as a separate feature as it applies to
both regular and custom events.

Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
@afrittoli afrittoli added this pull request to the merge queue Jul 9, 2024
Merged via the queue into cdevents:main with commit 935f556 Jul 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant