Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Unmark's importer to support new services #112

Closed
1 of 4 tasks
cdevroe opened this issue Feb 23, 2015 · 14 comments
Closed
1 of 4 tasks

Extend Unmark's importer to support new services #112

cdevroe opened this issue Feb 23, 2015 · 14 comments
Milestone

Comments

@cdevroe
Copy link
Owner

cdevroe commented Feb 23, 2015

Currently supported: Browser exports from Safari, Chrome, Firefox. Also Pinboard and Delicious.

What else would you like to see?

What else?

@cdevroe
Copy link
Owner Author

cdevroe commented Feb 24, 2015

@nothing-fr updated.

@w00kie
Copy link

w00kie commented Mar 5, 2015

kippt.com (exports to a "Netscape bookmarks html format")

@cdevroe
Copy link
Owner Author

cdevroe commented Mar 5, 2015

@w00kie Excellent! That means Unmark already supports importing it.

@JoshHrach
Copy link

Add a vote to Instapaper for me.

@ckrack
Copy link

ckrack commented Apr 20, 2015

Out of personal need i created importers as a custom extension to unmark.
https://github.com/ckrack/unmark/tree/custom-import

I will not create a pull request, as these already seem to be in the private code and the ones i created are tweaked as in creating tags for the bookmark folders of netscape import.
Also the code is not the cleanest, as i tried to use the Mark_Import class without changing it, and it's depending on checks like the one for export_version, that are dependent on the JSON Importer and are not needed for other imports..

@cdevroe
Copy link
Owner Author

cdevroe commented Apr 20, 2015

Cool @ckrack

@ckrack
Copy link

ckrack commented Apr 20, 2015

This is how i'd be going about it:

  • Create an interface that all importers use. Basically the importFile and validateUpload methods.
  • Make the counting and result returning simpler
  • uncouple the dependencies in Mark_Import
  • add a config option that contains the importers, which is then cycled over in the controller.
    $importers = ['delicious', 'json', 'pocket'];
    that way others can be added easily..

But then again, you might have all this already?

@virtadpt
Copy link

del.icio.us, which only allows export to HTML.

@virtadpt
Copy link

@ckrack you are a sir among beings - I just used your branch to import several thousand bookmarks from del.icio.us after a weekend of hacking to write a Netscape bookmarks-to-Unmark JSON document converter. Your code just saved my sanity - PLEASE file a pull request!

@cdevroe
Copy link
Owner Author

cdevroe commented Sep 15, 2016

@ckrack I'm going to look through your extension... as I didn't in the past and see what we can pull from it.

@cdevroe cdevroe added this to the 1.7.2 milestone Sep 20, 2016
@cdevroe
Copy link
Owner Author

cdevroe commented Sep 27, 2016

In #168 both Delicious and Pinboard now can be imported using their HTML format.

@smth
Copy link

smth commented Aug 6, 2017

So I should already be seeing an option to import from browser? I have 1.7.1.2 installed, and only see "Unmark file" and "Readability file".

@cdevroe
Copy link
Owner Author

cdevroe commented Sep 19, 2017

@smth Upgrade to 1.7.2 (if you haven't already using the branch) a little later today for this feature.

@cdevroe cdevroe closed this as completed Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants
@cdevroe @w00kie @ckrack @virtadpt @JoshHrach @smth and others