Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocrop Issue?? #178

Closed
bmcassagne opened this issue Jan 13, 2021 · 5 comments
Closed

Autocrop Issue?? #178

bmcassagne opened this issue Jan 13, 2021 · 5 comments
Labels
enhancement Improve existing feature

Comments

@bmcassagne
Copy link

bmcassagne commented Jan 13, 2021

Autocrop doesn't work properly on [a dark pallet movie]. It crops a large portion of the picture. Autocrop in general is made worse by the very small preview that also can't be changed to a different time in the movie. I will say this is the first problem I've noticed with autocrop in maybe 100 conversions. This movie has a lot of black background that is probably confusing autocrop. It's also interesting that the black seems to make the movie compress INCREDIBLY well.

@cdgriffith cdgriffith added the enhancement Improve existing feature label Jan 13, 2021
@cdgriffith
Copy link
Owner

I think the "answer" to that is having a configurable number of autocheck points. It works by using the FFmpeg cropdetect at 4 points throughout the movie. FastFlix will take that info and look for the one with the smallest amount of crop.

For darker movies probably better to have it configurable to 10 or so.

You can actually change the preview point of the video by setting a start time, and whichever start time you set it too will use that as the first crop detect point. (Not well documented, and I agree would be nice to have better way to set preview / crop points!)

Personally if it's 1 in a 100 I am ecstatic it works that well 😄, but there's always room to imporve, thanks for the report!

Also for a dark movie it might be compressing it tooo well and getting a lot of banding. May have to up the Adaptive Quantization to the 3 option with dark bias.

@bmcassagne
Copy link
Author

That's a good point about the movie but the compression seems to be fine. Dark movies are usually really noisy but this one seems to be extremely clean. Also there is a lot of black this is completely black. Like they intentionally clipped the black levels to give it a different look. And many of the backgrounds are soft which I think compresses better. The entire movie looks like it's going to wind up at 1.1 GB. 1080p with 960kbps audio. 21q video compression, 10-bit. Most movies with these settings wind up 6-9 GB.

cdgriffith added a commit that referenced this issue Jan 13, 2021
@E-t-z
Copy link

E-t-z commented Jan 14, 2021

As an side note, there are movies, with varying aspect ratios, so 4 is definitely too little for those.
Some examples: https://www.avsforum.com/threads/list-of-variable-aspect-ratio-movies-on-blu-ray.2811713/

@bmcassagne
Copy link
Author

Interesting that there are a LOT of superhero movies on that list. It's off topic but I saw for some reason Ant-Man and the Wasp is almost impossible to make VERY small. (I saw it on that list) I like to make movies 150-300mb to mostly listen to on my phone. If you go less than about 500 mb with that one you can't even recognize the faces. Even in the opening scene where there simply walking around a house. I've tried resolutions as low as 240p.

cdgriffith added a commit that referenced this issue Feb 14, 2021
* Adding #109 NVENC HEVC support based on FFmpeg
* Adding NVEenC encoder for HEVC and AVC
* Adding #166 More robust queue that is recoverable
* Adding ability to extract HDR10+ metadata if hdr10plus_parser is detected on path
* Adding #178 selector for number of autocrop positions throughout video (thanks to bmcassagne)
* Adding Windows 10 notification for queue complete success
* Adding #194 fast two pass encoding (thanks to Ugurtan)
* Fixing German translations (thanks to SMESH)
* Fixing #171 Be able to select encoder before selecting video
* Fixing #176 Unable to change queue order or delete task from queue since 4.1.0 (thanks to Etz)
* Fixing #185 need to specify channel layout when downmixing (thanks to Ugurtan)
* Fixing #187 cleaning up partial download of FFmpeg (thanks to Todd Wilkinson)
* Fixing #190 add missing chromaloc parameter for x265 (thanks to Etz)
* Fixing that returning item back from queue of a different encoder type would crash Fastflix
* Fixing HDR10 details to be track specific (thanks to Harybo)
cdgriffith added a commit that referenced this issue Apr 13, 2021
* Adding #109 NVENC HEVC support based on FFmpeg (thanks to Zeid164)
* Adding NVEenC encoder for HEVC and AVC
* Adding #166 More robust queue that is recoverable
* Adding ability to extract HDR10+ metadata if hdr10plus_parser is detected on path
* Adding #178 selector for number of autocrop positions throughout video (thanks to bmcassagne)
* Adding Windows 10 notification for queue complete success
* Adding #194 fast two pass encoding (thanks to Ugurtan)
* Adding Confirm dialogue for cancel encode and replace currently working on video
* Changing AVC defaults and recommendations for CRF to higher values
* Changing VP9 to default to mkv instead of webm format to support more audio codecs
* Fixing German translations (thanks to SMESH)
* Fixing #171 Be able to select encoder before selecting video
* Fixing #176 Unable to change queue order or delete task from queue since 4.1.0 (thanks to Etz)
* Fixing #185 need to specify channel layout when downmixing (thanks to Ugurtan)
* Fixing #187 cleaning up partial download of FFmpeg (thanks to Todd Wilkinson)
* Fixing #190 add missing chromaloc parameter for x265 (thanks to Etz)
* Fixing #209 Double spaces were removed in incoming filenames, causing no file found (thanks to stilicrafter)
* Fixing that deinterlace detection could crash program due to CPython bug issue #43423 (thanks to macx)
* Fixing that returning item back from queue of a different encoder type would crash Fastflix
* Fixing HDR10 details to be track specific (thanks to Harybo)
* Fixing returning from queue works with duplicated audio tracks

Co-authored-by: SMESH <4199206+smesh109@users.noreply.github.com>
Co-authored-by: TGMais <2453844+tgmais@users.noreply.github.com>
@cdgriffith
Copy link
Owner

Fixed in 4.2.0 https://github.com/cdgriffith/FastFlix/releases/tag/4.2.0 (can set number via setting panel)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing feature
Projects
None yet
Development

No branches or pull requests

3 participants