GitHub Actions: Test on Python 3.13 beta #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python 3.13 release notes mention `puremagic` as one of the alternatives for `imghdr` which was removed from the Standard Library so let's ensure that its tests pass on Python 3.13 beta. https://www.python.org/downloads/release/python-3130b1/ May raise `ModuleNotFoundError: No module named 'imghdr'` because Python 3.13 removes it from the Standard Library. * https://docs.python.org/3/library/imghdr.html > imghdr: use the projects [filetype](https://pypi.org/project/filetype/), [puremagic](https://pypi.org/project/puremagic/), or [python-magic](https://pypi.org/project/python-magic/) instead. (Contributed by Victor Stinner in [gh-104773](python/cpython#104773).) https://docs.python.org/3.13/whatsnew/3.13.html#pep-594-dead-batteries-and-other-module-removals
This was referenced May 11, 2024
Hi @cclauss I got an email with the above question but it's not showing up in this PR when I view it, I've cut'n'pasted it from the mail. I'm not sure I can help on that, I'm still fairly new to GitHub and have not played much with the workflow side of things. @cdgriffith the repo owner will be the best person to take a look. |
Merged
cdgriffith
added a commit
that referenced
this pull request
Jun 16, 2024
- Adding #72 #75 #76 #81 `.what()` to be a drop in replacement for `imghdr.what()` (thanks to Christian Clauss and Andy - NebularNerd) - Adding #67 Test on Python 3.13 beta (thanks to Christian Clauss) - Adding #77 from __future__ import annotations (thanks to Christian Clauss - Fixing #66 Confidence sorting (thanks to Andy - NebularNerd) --------- Co-authored-by: Andy <NebularNerd@users.noreply.github.com> Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python 3.13 release notes mention
puremagicas one of the alternatives forimghdrwhich was removed from the Standard Library so let's ensure that its tests pass on Python 3.13 beta.https://www.python.org/downloads/release/python-3130b1/
May raise
ModuleNotFoundError: No module named 'imghdr'because Python 3.13 removes it from the Standard Library.https://docs.python.org/3.13/whatsnew/3.13.html#pep-594-dead-batteries-and-other-module-removals